Closed ocavue closed 1 year ago
Hi! It seems some of the things asked in the template are missing? Please edit your post to fill out everything.
You won’t get any more notifications from me, but I’ll keep on updating this comment, and remove it when done!
Thanks, — bb
Some issues about the CI:
@ts-expect-error
. npm run test
is lower than 100%. However I could not find the uncovered code in mdast-util-to-markdown/coverage/lcov-report/index.html
, which shows 100%.
type-coverage is not coverage, it’s something else.
I’ve updated the internal types for zwitch
and TS 4.9: https://github.com/syntax-tree/mdast-util-to-markdown/commits/main.
The CI is green after rebasing the latest main
branch. Thanks for your helping.
If I improve the -
case and *
case by adding after
to these two rules, I cannot pass the test should prevent breaking out of code (-). It seems that inline-code.js
is reusing these unsafe patterns to transform EOL into whitespace. I'm not sure what's the best way to fix it. Should I create a separate pattern list for inline-code.js
(instead of reusing existed atBreak: true
patterns in unsafe.js
)?
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/*
labels.
I'm not sure what's the best way to fix it
These test check for something that was being escaped, but did not strictly need to be escaped. See https://github.com/syntax-tree/mdast-util-to-markdown/commit/2f3eeb7a5a258f21942c82ba47c47edb6b3284f6
Released, thanks! https://github.com/syntax-tree/mdast-util-to-markdown/releases/tag/1.4.0
Initial checklist
Description of changes
This PR improves the escape unsafe rule for
+
. If a+
is not followed by[\ \t\r\n]
, then it won't turn into a list item, thus we don't need to escape it.