Error at C:/web/node_modules/@types/unist/index.d.ts:92:58: ';' expected.

syntax-tree / unist

Universal Syntax Tree used by @unifiedjs

https://unifiedjs.com

875 stars 19 forks source link

Error at C:/web/node_modules/@types/unist/index.d.ts:92:58: ';' expected. #47

Closed mohamedumer closed 3 years ago

mohamedumer commented 3 years ago

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

@types/unist & 2.0.6

Link to runnable example

No response

Steps to reproduce

angular - 4.3.6 node- 10.15.0 react-markdown- 4.0.3 with above version if we try to build angular app, we are getting below error. MicrosoftTeams-image (7)

Expected behavior

it should build the app.

Actual behavior

due to @types/unist package issue we wont be able to build angular app.

Runtime

Other (please specify in steps to reproduce)

Package manager

yarn v1

OS

Windows, Linux

Build and bundle tools

Webpack

ChristianMurphy commented 3 years ago

Testing this out with Angular 11 this doesn't appear to be an issue https://codesandbox.io/s/angular-11-example-ssg15?file=/src/app/app.component.ts Could you try upgrading the TypeScript version you are using? unist and most of unified and remark currently support TypeScript version 3 or higher. In the next major release TypeScript 4 and higher. The error you as seeing looks like a TypeScript version 2 error.

github-actions[bot] commented 3 years ago

Hi! Thanks for taking the time to contribute! This has been marked by a maintainer as needing a reproduction: It’s not yet clear whether this is a problem. Here are a couple tips:

Thoroughly document how to reproduce the problem, in steps or with code
Don’t link to your complete project: make the repro as tiny as possible, preferrably with only the problematic project in question
Make sure you’re on the latest versions of projects (and node/npm/yarn!)
The best issue report is a failing test proving it

Thanks, — bb

github-actions[bot] commented 3 years ago

Hi team! I don’t know what’s up as there’s no phase label. Please add one so I know where it’s at.

Thanks, — bb

github-actions[bot] commented 3 years ago

Hi! Thanks for taking the time to contribute! This has been marked by a maintainer as needing a reproduction: It’s not yet clear whether this is a problem. Here are a couple tips:

Thoroughly document how to reproduce the problem, in steps or with code
Don’t link to your complete project: make the repro as tiny as possible, preferrably with only the problematic project in question
Make sure you’re on the latest versions of projects (and node/npm/yarn!)
The best issue report is a failing test proving it

Thanks, — bb

github-actions[bot] commented 3 years ago

Hi team! Could you describe why this has been marked as wontfix?

Thanks, — bb

ChristianMurphy commented 3 years ago

This works on supported versions of Angular (https://angular.io/guide/releases#support-policy-and-schedule) and supported versions of TypeScript (version 3+).

mohamedumer commented 3 years ago

We tried to upgrade Typescript greater than 3. but getting error while running yarn install, so we checked out with Ts 2.9.2 then the build is fine in local. where in pipeline still we are facing issue with the app build, which takes longer time, eventually getting failed. is there anything to consider apart from Typescript upgrade. @ChristianMurphy

ChristianMurphy commented 3 years ago

A TypeScript upgrade to version 3 or higher is the more consistent and likely way to get it to work.

You could try pinning older versions of types packages that are failing, so see if they work with legacy typescript. Or you could manually edit typings with https://github.com/ds300/patch-package#readme to remove features until it works with legacy typescript versions.