search

syntaxerrors / Steam

A composer package to make use of the steam web api.
https://packagist.org/packages/syntax/steam-api
MIT License
160 stars 55 forks source link

Update dependencies and add support for Laravel 8 #110

Closed bensherred closed 4 years ago

bensherred commented 4 years ago

This PR adds support for Laravel 8 (resolving #109) and updates the composer dependencies to the latest version.

Changelog

Note: Due to the number of core changes, it might be worth releasing a major version due to no longer supporting Laravel 5.8.

bensherred commented 4 years ago

@stygiansabyss how are you setting/handling the Steam API Key for Travis CI?

nicekiwi commented 4 years ago

@bensherred the API key is saved as an ENV variable in the Travis settings. If it's failing Shawn's key may have expired.

nicekiwi commented 4 years ago

Hmm updated the key to mine and still fails. The Steam API may have changed, assuming the ENV method is still the same. That's a worry.

nicekiwi commented 4 years ago

Tests are still passing on Master, i'll check out the code and have a look.

bensherred commented 4 years ago

All the tests work locally (made sure of that before committing) but doesn’t seem to work on Travis CI

nicekiwi commented 4 years ago

@bensherred ok from what I can see in the Travis docs: https://docs.travis-ci.com/user/environment-variables/#defining-encrypted-variables-in-travisyml

"Similarly, we do not provide these values to untrusted builds, triggered by pull requests from another repository."

As your PR is from a fork, not a direct PR on the BASE repo the build wont have access to the API key.

I'm happy to merge this now and trigger a packagist release.

nicekiwi commented 4 years ago

@bensherred Thank you for your contribution 🌮 😃

bensherred commented 4 years ago

No worries at all @nicekiwi, glad I could help!