search

synth-inference / synthdid

Synthetic difference in differences
https://synth-inference.github.io/synthdid
BSD 3-Clause "New" or "Revised" License
261 stars 96 forks source link

error in synthdid_placebo #82

Open awhitefield8 opened 2 years ago

awhitefield8 commented 2 years ago

Hi, there may be a typo in the synthdid_placebo function here: On line 155, the following argument has a loose comma at the end that may be causing issues: list(Y=setup$Y[, 1:setup$T0], N0=setup$N0, T0=placebo.T0, X=setup$X[, 1:setup$T0,], <<<missing argument here?>>> )

davidahirshberg commented 2 years ago

That’s not a typo.  X should be 3D array: units x time periods x covariates.  What problems are you having that you’re thinking might trace back there? On Mar 12, 2022, 6:04 PM -0500, synth-inference/synthdid @.***>, wrote:

N0

davidahirshberg commented 2 years ago

Oh, I see now. Thanks for pointing it out.  Want to submit a PR fixing the issue? On Mar 12, 2022, 6:04 PM -0500, awhitefield8 @.***>, wrote:

Hi, there may be a typo in the synthdid_placebo function here: On line 155, the following argument has a lose comma at the end that may be causing issues: list(Y=setup$Y[, 1:setup$T0], N0=setup$N0, T0=placebo.T0, X=setup$X[, 1:setup$T0,], <<<missing argument here?>>> ) — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.Message ID: @.***>