search

synth / mail_jack

Autogenerate query parameters to links in emails to track click throughs
MIT License
2 stars 2 forks source link

link replacement is broken in some situations #3

Open synth opened 11 years ago

synth commented 11 years ago

if you have "myapp.com/signup/verify?token=abc" and then later a different link,say: "myapp.com"

replacement will occur poorly, doing the replacement of the first properly, but when we replace the second, it also replaces the first causing this malformed link:

myapp.com?source=abc/signup/verify?token=abc&source=abc

synth commented 11 years ago

yea, this is an issue when links appear that are a substring of other links, such as in root links. so this is pretty much a blocker for now...