synthego-open / ice

Synthego ICE - Inference of CRISPR Editing software
Other
66 stars 30 forks source link

pytest fail on v1.1.0 #26

Closed tdfy closed 4 years ago

tdfy commented 4 years ago

Hello,

It is essential that I run a prior version to validate prior results. Please advise on the pytest failure, also observed in treatment data. Thanks.

-------------------------------------------------- analyzing 8 donor_no_alignment AAGTGCAGCTCGTCCGGCGT
Base dir: /tmp/tmpxqi1g4d4/batch_analysis
Single Sanger analysis failed ord() expected string of length 1, but int found
Traceback (most recent call last):
  File "/home/tdfyoder/GIT/ice_v1.X/ice/ice/analysis.py", line 186, in multiple_sanger_analysis
    result = single_sanger_analysis(*job_args, **job_kwargs)
  File "/home/tdfyoder/GIT/ice_v1.X/ice/ice/analysis.py", line 77, in single_sanger_analysis
    donor=donor)
  File "/home/tdfyoder/GIT/ice_v1.X/ice/ice/classes/sanger_analysis.py", line 126, in initialize_with
    control_sample.initialize_from_path(control_path)
  File "/home/tdfyoder/GIT/ice_v1.X/ice/ice/classes/sanger_object.py", line 80, in initialize_from_path
    phred_scores.append(ord(c))
TypeError: ord() expected string of length 1, but int found
None of the samples were able to be analyzed
False
===================================== 14 failed, 31 passed in 1.82 seconds ======================================
tdfy commented 4 years ago

for fix refer to commit 04143d3