search

syntheses / commonplace

A self-hosted tumblelog replacement
0 stars 2 forks source link

Add .is-opening for opening animation #23

Open jrubenoff opened 10 years ago

jrubenoff commented 10 years ago

Just realized that we still need the .is-hidden class for the opening animation.

commonplace

Note how "Link" and "Video" start out opaque, and then suddenly disappear when sliding into place. Instead, they should become progressively visible. (To be clear, the bug isn't specific to those two buttons, but the delay is sufficiently long enough on the last two buttons that you can see the problem easily.)

Assigning this to you because the only clean way I can think of to do this involves the animationEnd event in public/js/script.js. #3 referred to how this event was not being fired if you started a post and returned back to the form.

maxmechanic commented 10 years ago

What is the sequence of class addition/removal that you are styling for?

jrubenoff commented 10 years ago

So... I keep reminding myself of additional complexity. I've created the branch animations to reflect the changes below.

When the page loads

All subsequent interactions (returning from the main view to the post form, etc.)

We should have a better way to communicate this stuff than HTML / CSS prototypes that aren't in the repo. Normally I just implement this stuff myself and work through the complexity in code. Or maybe this is just good practice for both of us?

maxmechanic commented 10 years ago

It's trickier with React, but there are solutions, albeit ones that may still be in flux (no pun). Other frameworks that are jQuery-based are a bit more directly portable from the mocks.