search

syntheses / commonplace

A self-hosted tumblelog replacement
0 stars 2 forks source link

Initial error-handling #28

Open maxmechanic opened 10 years ago

maxmechanic commented 10 years ago

Launcher now has a span (element/class/etc all totally changeable) for errors to drop into if the server returns any or if there's a problem with making the AJAX request. Works as a nice pattern for any type of flash message.

Right now it'll get filled with verbatim errors from Node for post file creation and Jekyll build errors. Might be good to delete the newly-created post file if it's causing build failure.

Also fixed an issue where seconds in the date property of YAML front-matter were causing errors.

jrubenoff commented 10 years ago

Looks like you might need to character escape... React is translating stuff inappropriately.

Sample error in Terminal:

screen shot 2014-06-13 at 8 24 54 am

Sample error in Commonplace (note the data-reactid):

screen shot 2014-06-13 at 8 25 33 am

jrubenoff commented 10 years ago

Also, are we able to tell where the error's coming from? Might be nice to prepend errors with phrases like "Error building Jekyll", "Couldn't create post", etc.

maxmechanic commented 10 years ago

I've parsed out file-creation errors from Jekyll errors. Right now it's still just printing into <pre> tags but we should talk about the best way to display this info. All the plumbing is in place for what you're talking about, though.

Errors should be appropriately formatted/stringified now.

jrubenoff commented 10 years ago

Don't mean to be a stickler, but how can I test this? Can't seem to generate an error.

maxmechanic commented 10 years ago

Try a way-too-long title to check file creation limits. Putting a colon in the title should make Jekyll angry.