synthesized-io / insight

🧿 Metrics & Monitoring of Datasets
BSD 3-Clause "New" or "Revised" License
12 stars 0 forks source link

Use correct metric name #145

Closed nialldevlin1 closed 7 months ago

nialldevlin1 commented 10 months ago

The 'OneColumnMapandTwoColumnMap` classes each create a pd.Series object with column name "metric_val". This PR updates the column name to reflect the metric that is actually being calculated

codecov[bot] commented 10 months ago

Codecov Report

Merging #145 (11c800b) into master (f2e861e) will not change coverage. The diff coverage is 100.0%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/synthesized-io/insight/pull/145/graphs/tree.svg?width=650&height=150&src=pr&token=S8CD8EN4AF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synthesized-io)](https://app.codecov.io/gh/synthesized-io/insight/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synthesized-io) ```diff @@ Coverage Diff @@ ## master #145 +/- ## ====================================== Coverage 79.6% 79.6% ====================================== Files 11 11 Lines 916 916 Branches 141 141 ====================================== Hits 730 730 Misses 142 142 Partials 44 44 ``` | [Files](https://app.codecov.io/gh/synthesized-io/insight/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synthesized-io) | Coverage Δ | | |---|---|---| | [src/insight/metrics/metrics\_usage.py](https://app.codecov.io/gh/synthesized-io/insight/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synthesized-io#diff-c3JjL2luc2lnaHQvbWV0cmljcy9tZXRyaWNzX3VzYWdlLnB5) | `94.1% <100.0%> (ø)` | |
sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud