synthesized-io / insight

🧿 Metrics & Monitoring of Datasets
BSD 3-Clause "New" or "Revised" License
12 stars 0 forks source link

Fixed check.continuous to accept int32, float32 and uint32 #159

Closed marqueewinq closed 6 months ago

marqueewinq commented 6 months ago

The following code produced "Number of categories exceeded threshold" message if any of dfs contained any of the types int32, float32, uint32:

from insight import plot as p
fig = p.dataset([df_eval, df_synth_eval])

This PR fixes the incorrect behaviour + adds a failing test.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5f19bc5) 79.9% compared to head (a644dbf) 79.9%.

:exclamation: Current head a644dbf differs from pull request most recent head bf4051a. Consider uploading reports for the commit bf4051a to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/synthesized-io/insight/pull/159/graphs/tree.svg?width=650&height=150&src=pr&token=S8CD8EN4AF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synthesized-io)](https://app.codecov.io/gh/synthesized-io/insight/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synthesized-io) ```diff @@ Coverage Diff @@ ## master #159 +/- ## ====================================== Coverage 79.9% 79.9% ====================================== Files 11 11 Lines 927 927 Branches 145 145 ====================================== Hits 741 741 Misses 142 142 Partials 44 44 ``` | [Files](https://app.codecov.io/gh/synthesized-io/insight/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synthesized-io) | Coverage Δ | | |---|---|---| | [src/insight/check.py](https://app.codecov.io/gh/synthesized-io/insight/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synthesized-io#diff-c3JjL2luc2lnaHQvY2hlY2sucHk=) | `88.4% <ø> (ø)` | |
sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud