Closed tomcarter23 closed 5 months ago
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5f215f8
) 78.6% compared to head (b984297
) 78.6%.
With the current setup, where there was 1 or more NaN values in either of the
pd.Series
used in the KS calculation NaN was returned. This is not the desired behaviour, instead we want NaN values to be ignored.This PR adjusts the metric to ensure that NaN values are dropped from each series before calculation.