synthetichealth / synthea

Synthetic Patient Population Simulator
https://synthetichealth.github.io/synthea
Apache License 2.0
2.19k stars 657 forks source link

Wellness Encounters [Record_Height [Observation]] #148

Closed jeffeastman closed 7 years ago

jeffeastman commented 7 years ago

Looks to me like these ought to be VitalSign states and not Observations. According to the Wiki, only vital signs have the vital_sign field.

jeffeastman commented 7 years ago

Also some in metabolic_syndrome_disease and metabolic_syndrome_care

jeffeastman commented 7 years ago

I changed these Observations to VitalSigns, but many have no exact or range, so I assume these are not required by Synthea. I'm guessing these vitals are managed by the Ruby code and having no exact or range means to use the managed values instead?

"The VitalSign state type indicates a point in the module where a patient's vital sign is set. Vital Signs represent the physical state of the patient, in contrast to Observations which are the recording of that physical state."

dehall commented 7 years ago

Observations are allowed to have the vital_sign field - that indicates that instead of directly specifying a value or range of possible values, the value of the corresponding VitalSign is recorded in the Observation. You're right that the vital signs in question are managed by the ruby code (specifically https://github.com/synthetichealth/synthea/blob/master/lib/modules/lifecycle.rb#L165 ).

Ideally I'd like to have as many vital signs as possible represented in the GMF instead of in the ruby code, but many vital signs have complex formulas, which we haven't found a good way to represent in the GMF yet.

jeffeastman commented 7 years ago

Ok, I see that now. Was it there before? I can't imagine that I missed it.

jeffeastman commented 7 years ago

I've implemented vital_sign in Observation but now I'm finding situations where no vital sign was recorded before the observation requested it (e.g. Height). What's the recommended implementation?

jawalonoski commented 7 years ago

Some of the vital signs are assigned at birth so that doesn't happen in our system.

jeffeastman commented 7 years ago

Thanks, I do that too but I was just wanting a clarification. For signs like height and weight, I see you have assigned trajectories for them. Height levels off around 21 and weight increase slows down after then (depending upon diet and exercise risks)?

jawalonoski commented 7 years ago

Yes, that is right. Weight also stabilizes at age 49 then starts to decrease at 60. Those are configurable, and there are citations in the config/synthea.yml file.

jeffeastman commented 7 years ago

Closing this issue as it has been resolved