synthetichealth / synthea

Synthetic Patient Population Simulator
https://synthetichealth.github.io/synthea
Apache License 2.0
2.18k stars 653 forks source link

Use of Unicode zero width space character in module JSON files #590

Closed gmyers18 closed 5 years ago

gmyers18 commented 5 years ago

I noticed that several module JSON files contain the Unicode zero width space character in their display text. This is challenging to notice in many editors and it occurred to me that perhaps this was not intentional.

Below is a dump of the lines where this occurs. The zero width space frequently (always?) follows a forward slash character. The dump of course does not show the character, but its presence can be observed in the Module Builder, as an example, where it is highlighted in red:

image

$ git rev-parse HEAD
c9ce384226c2aa72c739a935634fb3b6e6ab322c

$ grep -n -r $'\u200b' .
./colorectal_cancer.json:1829:              "display": "Leukocytes [#/​volume] in Blood by Automated count"
./colorectal_cancer.json:1844:              "display": "Erythrocytes [#/​volume] in Blood by Automated count"
./colorectal_cancer.json:1859:              "display": "Hemoglobin [Mass/​volume] in Blood"
./colorectal_cancer.json:1920:              "display": "MCHC [Mass/​volume] by Automated count"
./colorectal_cancer.json:1950:              "display": "Platelets [#/​volume] in Blood by Automated count"
./congestive_heart_failure.json:903:              "display": "Glomerular filtration rate/​1.73 sq M.predicted"
./congestive_heart_failure.json:918:              "display": "Protein [Mass/​volume] in Serum or Plasma"
./congestive_heart_failure.json:933:              "display": "Albumin [Mass/​volume] in Serum or Plasma"
./congestive_heart_failure.json:948:              "display": "Globulin [Mass/​volume] in Serum by calculation"
./congestive_heart_failure.json:963:              "display": "Bilirubin.total [Mass/​volume] in Serum or Plasma"
./congestive_heart_failure.json:978:              "display": "Alkaline phosphatase [Enzymatic activity/​volume] in Serum or Plasma"
./congestive_heart_failure.json:993:              "display": "Alanine aminotransferase [Enzymatic activity/​volume] in Serum or Plasma"
./congestive_heart_failure.json:1008:              "display": "Aspartate aminotransferase [Enzymatic activity/​volume] in Serum or Plasma"
./lung_cancer.json:2145:              "display": "Leukocytes [#/​volume] in Blood by Automated count"
./lung_cancer.json:2160:              "display": "Erythrocytes [#/​volume] in Blood by Automated count"
./lung_cancer.json:2175:              "display": "Hemoglobin [Mass/​volume] in Blood"
./lung_cancer.json:2236:              "display": "MCHC [Mass/​volume] by Automated count"
./lung_cancer.json:2266:              "display": "Platelets [#/​volume] in Blood by Automated count"
./lung_cancer.json:2324:              "display": "Leukocytes [#/​volume] in Blood by Automated count"
./lung_cancer.json:2339:              "display": "Erythrocytes [#/​volume] in Blood by Automated count"
./lung_cancer.json:2354:              "display": "Hemoglobin [Mass/​volume] in Blood"
./lung_cancer.json:2415:              "display": "MCHC [Mass/​volume] by Automated count"
./lung_cancer.json:2445:              "display": "Platelets [#/​volume] in Blood by Automated count"
./metabolic_syndrome_care.json:2447:              "display": "Glomerular filtration rate/​1.73 sq M.predicted"
./metabolic_syndrome_care.json:2574:              "display": "Glomerular filtration rate/​1.73 sq M.predicted"
./metabolic_syndrome_care.json:2701:              "display": "Glomerular filtration rate/​1.73 sq M.predicted"
./metabolic_syndrome_care.json:2828:              "display": "Glomerular filtration rate/​1.73 sq M.predicted"
./metabolic_syndrome_care.json:2955:              "display": "Glomerular filtration rate/​1.73 sq M.predicted"
./metabolic_syndrome_care.json:3046:              "display": "Glucose [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3077:              "display": "Bilirubin.total [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3109:              "display": "Ketones [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3170:              "display": "Protein [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3325:              "display": "Glucose [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3356:              "display": "Bilirubin.total [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3388:              "display": "Ketones [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3449:              "display": "Protein [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3604:              "display": "Glucose [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3635:              "display": "Bilirubin.total [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3667:              "display": "Ketones [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3728:              "display": "Protein [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3883:              "display": "Glucose [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3914:              "display": "Bilirubin.total [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:3946:              "display": "Ketones [Mass/​volume] in Urine by Test strip"
./metabolic_syndrome_care.json:4007:              "display": "Protein [Mass/​volume] in Urine by Test strip"
./veteran_prostate_cancer.json:1091:              "display": "Leukocytes [#/​volume] in Blood by Automated count"
./veteran_prostate_cancer.json:1106:              "display": "Erythrocytes [#/​volume] in Blood by Automated count"
./veteran_prostate_cancer.json:1121:              "display": "Hemoglobin [Mass/​volume] in Blood"
./veteran_prostate_cancer.json:1182:              "display": "MCHC [Mass/​volume] by Automated count"
./veteran_prostate_cancer.json:1212:              "display": "Platelets [#/​volume] in Blood by Automated count"
jawalonoski commented 5 years ago

Hmm. Weird and definitely not intentional. Thanks for the issue report.