synthetos / TinyG

Affordable Industrial Grade Motion Control
https://github.com/synthetos/TinyG/wiki
887 stars 293 forks source link

mp_plan_hold_callback() issue #252

Open siberianfox opened 4 years ago

siberianfox commented 4 years ago

Hi everyone:

I just trying to understand these code how to work, and I found the feedhold function callback mp_plan_hold_callback() maybe conflict with the mp_exec_aline() which is calling from the exec timer interrupt. Because both of these functions will read and calculate the data in mr structure, and I think sometime the interrupt will trigger and make the data incorrect.

Is there someone who can tell me if these are correct.