search

synthetos / TinyG

Affordable Industrial Grade Motion Control
https://github.com/synthetos/TinyG/wiki
893 stars 293 forks source link

Error in source code #264

Open DmitriiZorin opened 3 years ago

DmitriiZorin commented 3 years ago

https://github.com/synthetos/TinyG/blob/39df38c0e5830721fb2d16a7ae7b44816d24c4c4/firmware/tinyg/plan_exec.c#L382 Hello. I think that the line 382 in file plan_exec.c meant to be: float half_Ah_5 = A half_h half_h half_h half_h * half_h; Am i right? If not then did i misunderstood something?

lagnat commented 3 years ago

You're probably right and it looks like that bug was already fixed in G2.

https://github.com/synthetos/g2/blob/edge/g2core/plan_exec.cpp#L728