search

synthetos / TinyG

Affordable Industrial Grade Motion Control
https://github.com/synthetos/TinyG/wiki
887 stars 293 forks source link

feedrate override with cncjs #273

Open kbex1 opened 2 years ago

kbex1 commented 2 years ago

i think i might be missing something here, i'm running the latest firmware on a tinyG v8 (Edge-449.01) and the lastest cncjs 1.9.22. with JSON enabled {sso:n} is not recognized, and is not mentioned in the docs. it is not supported anymore ? (or the more likely scenario i'm missing some configuration )

Thanks

kbex1 commented 2 years ago

after some digging i found the the spindle code that supports the feedrate is only on branch edge 0.98 and was never merged into the other "edge" branch master-449.

@aldenhart is there something i should be aware of before i merge the 0.98 spindle code that supports the federate override to the master-449 branch ?

i can test it with my machine but before i solve the merge conflicts for the "master-449" branch and such, is there a reason just taking the code from edge-0.98 for the spindle.h and spindle.c and compiling shouldn't work? it seems there was only one commit for it in 444.18 on the edge-0.98 branch.

thanks kfir