Motion Mode changes at the end of sending gcode files

synthetos / TinyG

Affordable Industrial Grade Motion Control

https://github.com/synthetos/TinyG/wiki

897 stars 293 forks source link

Motion Mode changes at the end of sending gcode files #39

Closed ril3y closed 11 years ago

ril3y commented 11 years ago

This almost happens at random spots but as you can see here:

384907 [ResponseParser] INFO tgfx.ResponseParser - Got Line: {"sr":{"line":1485,"mpox":75.579,"mpoy":142.911,"momo":0}} from TinyG.

the "momo" changed however there was no G0 commands near line 1485. The file that I was testing this on was mudflap_50inch.gcode. This file is located in gcode_samples directory in all branches of TinyG.

This has been also observed in Braid during the end box drawings.

aldenhart commented 11 years ago

I see what's happening here. In status reports motion mode (momo) is being reported incorrectly. The status report reflects the immediate value of momo, not the momo of the line that is running. This can make it appear that the motion mode is incorrect, especially when a series of short G0 and G1's are intermixed. Like at the box drawing portion of the braid test.

aldenhart commented 11 years ago

This should be fixed in 378.02 (edge). After some independent testing I'll declare this closed and push to master.