search

synthetos / g2

g2core - The Next Generation
Other
622 stars 296 forks source link

Acceleration messed up after G38.2 probing #474

Closed mhlong10 closed 3 years ago

mhlong10 commented 3 years ago

I've finally root caused an issue which was causing my machine to bang and jerk around. It doesn't do this when I manually zero Z but does when I use the touch-plate.

I notice this bug is in both edge and edge-preview.

_probe_start saves the jerk_max values and _probe_restore_settings restores those values. The issue is that restore directly sets the values rather than calling cm_set_axis_max_jerk which recalculate max_junction_accel. This means max_junction_accel doesn't get restored and the machine continues to use the value calculated we set jerk_max was set to jerk_high for the probing cycle.

mhlong10 commented 3 years ago

Submitted PR https://github.com/synthetos/g2/pull/475 to address issue.

justinclift commented 3 years ago

Sounds like a really good catch. :smile:

justinclift commented 3 years ago

Closing this, as #475 has been merged. Thanks heaps @mhlong10. :smile: