search

synthetos / g2

g2core - The Next Generation
Other
622 stars 296 forks source link

Revert "Fix U,V,W axis operation, most notably homing, probing and moving with proper feed rates." #501

Closed ril3y closed 2 years ago

ril3y commented 2 years ago

Reverts synthetos/g2#491

justinclift commented 2 years ago

Out of curiosity, what was broken by the patch? :smile:

ril3y commented 2 years ago

i applied it to the wrong branch. needed to pull it to edge-preview I hosed it and did not fix it yet. Git fight.

On Sun, Nov 14, 2021 at 10:08 AM Justin Clift @.***> wrote:

Out of curiosity, what was broken by the patch? 😄

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/synthetos/g2/pull/501#issuecomment-968308200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSMYSZKLGU2ZMZZNYF33UL7GGHANCNFSM5HOOE2WQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

prof7bit commented 10 months ago

Has this ever been integrated into edge-preview? For example it looks like the homing code there is still the same 4-axes-only if/else construct, the commit that made it properly print out the axis names for UVW-axes is also still the old code. This PR addressed a lot of different bugs i found when trying to use more than 3 linear axes.

Unfortunately I do not have the time to help working these into the preview branch myself at the moment, since my boss keeps me busy actually USING as it is in my own repository (edge + patches) because we absolutely NEED more than 3 linear axes and I don't have the time to switch the branch and do all the work again. It took me weeks to find and fix all these bugs.

Someone of the core contributors should really try to setup some test hardware with xyz and uvw axes and corresponding limit switches connected to actually observe (and fix) the problems himself. The individual commits in this PR can give a hint of what I had to change, so at least a few weeks of debugging could be saved this time.

I would gladly do it myself, but my boss probably won't allow me to spend much time to get it to work with the preview branch.

I would vote for reapplying this PR to edge, so there could exist at least ONE branch that can work with xyzuvw until it is all integrated into preview. I am sure I am not the only potential user who could need a controller with more than 3 linear axes (I for example have 4 linear and 1 rotational).