fix flush command handling and Windows PNP ID regex

synthetos / node-g2core-api

NodeJS host communications, API and command line interface for g2 CNC system

GNU General Public License v2.0

8 stars 6 forks source link

fix flush command handling and Windows PNP ID regex #7

Open thingersoft opened 6 years ago

thingersoft commented 6 years ago

fixes #5, fixes #6

thingersoft commented 6 years ago

These are small changes so I combined both fixes into a single PR. If you would rather split it let me know.

giseburt commented 6 years ago

So far this looks good. Generally I’d prefer them to be split but in this case it’ll be fine I’m sure.

I like the flush handling. I want to verify that works well with file sending (it should cancel the file send), which is a loosely related problem.

thingersoft commented 6 years ago

Hello, actually I didn't look much into file sending as I don't make use of it. So I agree it's better to test it thoroughly before merging. Let me know if any modification is needed.