search

synw / snowind-stories

A storybook presenting the Snowind components
2 stars 1 forks source link

Replace rollup-plugin-typescript2 by antfu/eslint-config #2

Closed micheartin closed 3 years ago

synw commented 3 years ago

It looks good except for the antfu/eslint-config : it is a bit too opinionated to me, specially the single quote rule or the one for endline ; signs. It does not play well with existing codebases, I think it would be better to leave this to the user and not enforce such specific lint opinions

synw commented 3 years ago

About the Refactor "yarn run" scripts commit the command vite --port 8080 --open is a bit too opinionated to me: personally I don't like auto-open: we could provide distinct auto-open commands. In general if we can stay close to standard defaults and leave opinions to the user it's better About the port we should leave this to the default: 3000 for dev and 5000 for preview. And maybe provide a command for those who prefer the good old 8080?

micheartin commented 3 years ago

Refactored the commit « Refactor "yarn run" scripts » to stay close to standard defaults by removing auto-open and keeping ports 3000 and 5000 for yarn dev and yarn preview. I do not care about the good old 8080. If the user wants auto-open, they can yarn dev --open. Same for a custom port.

micheartin commented 3 years ago

This PR is replaced by two others: