synzen / MonitoRSS

MonitoRSS RSS bot (formerly known as Discord.RSS) with customizable feeds. https://monitorss.xyz
https://monitorss.xyz
MIT License
1.05k stars 237 forks source link

Remove environment variable overrides #361

Closed sau226 closed 7 months ago

sau226 commented 7 months ago

According to https://docs.docker.com/compose/environment-variables/envvars-precedence/, anything set in the environment section of docker-compose.yml overrides anything specified in an env file (such as .env.prod for selfhosters).

This PR goes through and removes all env vars defined in .env.example (by default) from docker-compose.yml, so the settings in .env.prod or similar env files have effect.

Naturally, more variables can be added to .env.example and removed from the docker-compose.yml if you want to make them easier for users to customize.

synzen commented 7 months ago

Thanks for catching these!