html to markdown issues

synzen / MonitoRSS

MonitoRSS RSS bot (formerly known as Discord.RSS) with customizable feeds. https://monitorss.xyz

https://monitorss.xyz

MIT License

1.05k stars 237 forks source link

Closed m417z closed 5 months ago

m417z commented 7 months ago

I have a feed with a post similar to the following:

<p>test1 <strong>test2</strong> test3 <code>test4</code>.</p>

I got the following markdown in the Discord publication:

test1
**test2**test3
`test4`
.

Notice the newlines and the lack of space after test2. Expexted:

test1 **test2** test3 `test4`.

Steps to reproduce the behavior:

See above.

If applicable, add screenshots to help explain your problem.

public bot

Add any other context about the problem here.

m417z commented 6 months ago

I also noticed that a simple link isn't handled, even though it's supported by Discord's markdown. For example:

text <a href="https://example.com/">link</a> more text

Just turns into:

text link more text

Instead of:

text [link](https://example.com/) more text

synzen commented 6 months ago

Apologies for the delay here

As for the first issue you've posted, I've not yet had time to tackle a solution for this - it seems like there may be some complexity involved. I'll update this issue once there's another update
This is interesting - it's currently this way because Discord only supported masked links within certain fields of embeds, and not anywhere else. It looks support has been added now within the message content itself. I believe the best way forward to add support for this (without potentially breaking existing feeds) is to explicitly add another config in the control panel (that would be toggled on by default for newly added feeds) to opt into masked links. I'll update this issue once it's been added as well

synzen commented 5 months ago