Can't be used with `extends` as it declare `depends_on`

synzen / MonitoRSS

MonitoRSS RSS bot (formerly known as Discord.RSS) with customizable feeds. https://monitorss.xyz

https://monitorss.xyz

MIT License

1.05k stars 237 forks source link

Can't be used with `extends` as it declare `depends_on` #371

Closed Ducote closed 3 months ago

Ducote commented 3 months ago

Describe the bug

Building with docker compose won't work on recent version.

To Reproduce

Steps to reproduce the behavior:

Follow the tutorial :

Clone git main branch.
(Optionnal) Complete .env.prod.
Use docker compose up -d
See error

Expected behavior

service "discord-rest-listener-service" can't be used with extends as it declare depends_on

Observed behavior

MonitoRSS building

Screenshots

Branch (please specify one):

main

Additional context

Docker version 25.0.4, build 1a576c5 Docker Compose version v2.24.7 Ubuntu 22.04.4 LTS

When trying to resolve this issue, other services have this error.

synzen commented 3 months ago

Apologies for the delay in my response - it appears this is a known issue with the more recent versions of docker/docker compose: https://github.com/docker/compose/issues/11544

I'm having trouble understanding its release process to see when it will be fixed, but I assume that once the issue is closed, you can try updating docker for it to be resolved

In the meantime, I can confirm that Docker Engine 25.0.3/Docker Compose v2.24.5 appears to work on my end, if you're able to pin the version that you're using

Ducote commented 3 months ago

I pinned both versions in additional context. Heree they are :

Docker version 25.0.4, build 1a576c5
Docker Compose version v2.24.7

synzen commented 3 months ago

Apologies for the confusion - when I said pin the version, I mean directly set the version that you're using to match what I mentioned

mustafasegf commented 3 months ago

Hi, I'm have the same issue when using docker compose version v2.24.6. When I upgrade to v2.25.0 it runs fine. Since this is a bug in docker compose and already fixed, I think it's safe to close the issue

Ducote commented 3 months ago

I apologise, I must be missing something, or maybe I did something wrong.

Here's (maybe) what's the closest to an answer I can give you.

Partial result from my history

  776  git clone https://github.com/synzen/MonitoRSS.git
  777  cd MonitoRSS/
  778  ls
  779  cp .env.example .env.prod
  780  nano .env.prod 
  781  docker compose up -d
  782  docker compose --parallel 1 up -d

According to stat command, I cloned the repos on 2024-03-14 22:54:12.523349029 +0000

mustafasegf commented 3 months ago

I apologise, I must be missing something, or maybe I did something wrong.

Here's (maybe) what's the closest to an answer I can give you.

Partial result from my history
  776  git clone https://github.com/synzen/MonitoRSS.git
  777  cd MonitoRSS/
  778  ls
  779  cp .env.example .env.prod
  780  nano .env.prod 
  781  docker compose up -d
  782  docker compose --parallel 1 up -d
According to stat command, I cloned the repos on 2024-03-14 22:54:12.523349029 +0000

Hi there, you didn't do anything wrong. There's a bug in docker compose and it got fixed in the latest release. Try to upgrade your docker compose version to 2.25.0

synzen commented 3 months ago

Thanks for confirming @mustafasegf