search

syohex / emacs-counsel-gtags

GNU Global with ivy completion
62 stars 20 forks source link

Bugfix: use `with-selected-window` when not using `ivy-read`. #31

Closed whatacold closed 4 years ago

whatacold commented 6 years ago

Hi,

There is a nasty bug here that bothers me for some time, today I've figured out why: it's because we use with-ivy-window when we don't call ivy-read for the only candidate.

It can be reproduced by:

  1. open a file of a c file of some project, say redis, and create the tags
  2. open another window side by side, do some ivy-related operations, e.g. ivy-switch-buffer
  3. back to the original window, M-x counsel-gtags-dwim on any symbol, then you will see the buffer is shown in the window of step 2.
whatacold commented 6 years ago

I've just noticed that there is a ivy-auto-select-single-candidate option from #20 , after creating this. With that merged, this bug doesn't exist any more.

If you merge that, please just ignore and close this PR.

syohex commented 4 years ago

Sorry this package is no longer maintained. If you have an issue, please send it to https://github.com/FelipeLema/emacs-counsel-gtags