search

syoyo / tinydng

Header-only Tiny DNG/TIFF loader and writer in C++
MIT License
151 stars 30 forks source link

TIFF/EXIF tags: Fix potential 32bit unsigned integer overflow #43

Closed mdietsch closed 3 months ago

mdietsch commented 3 months ago

...for rational type in metadata.

I ran into an issue with for example using 0.000493 secs for exposure time. This change fixes this.

syoyo commented 3 months ago

Thanks! Let me give some time to review the PR

mdietsch commented 3 months ago

This is the code-snippet I used to investigate this issue: godbolt Line 11 lets you toggle between my fix and the original code

It may be of help

syoyo commented 3 months ago

This is the code-snippet I used to investigate this issue: godbolt Line 11 lets you toggle between my fix and the original code

It may be of help

Thanks! It saves my time to write a test! Confirmed the code, and it works. So merged!