Add missing extras and extensions fields

syoyo / tinygltf

Header only C++11 tiny glTF 2.0 library

MIT License

2.04k stars 413 forks source link

Add missing extras and extensions fields #422

Closed agnat closed 1 year ago

agnat commented 1 year ago

Hi syoyo,

this PR adds a number of missing extras and extension fields, mostly to nested "sub-objects". I also refactored the parsing and serialization code for these fields, so it's easier to maintain.

Last, I got rid of std::function by rewriting ForEachInArray(...) as a plain old template function. Also, fixed a warning introduced in #417...

Let me know what you think...

syoyo commented 1 year ago

Nice! Please split this PR to two separated PRs:

extras&extension
ForEachInArray rewrite

These are orthogonal features

agnat commented 1 year ago

I moved the ForEachInArray() rewrite to #424

syoyo commented 1 year ago

Thanks! Merged!