search

syoyo / tinyobjloader-c

Header only tiny wavefront .obj loader in pure C99
412 stars 60 forks source link

C89 compatibility is incorrect claim #6

Closed slapin closed 2 years ago

slapin commented 6 years ago

The code uses in-loop initializers (i.e. for int x...) and C++ comments, so it is not pure C89 code. It is C99-style code.

syoyo commented 6 years ago

Hmm... Some contributed code uses C99 style. Will fix it soon(Your PR is always welcome, though)

leok7v commented 6 years ago

Just a suggestion maybe just change the claim to C99. It's 2018 and even Microsoft is switching to clang and gcc and both support C99 for a long time... It's actually easier to read and less error prone.

syoyo commented 6 years ago

I see. > It's actually easier to read and less error prone.

Even though I did some C99 -> C89 fix in this commit https://github.com/syoyo/tinyobjloader-c/commit/8daec4d18a28c1d0522ce16ee1e2c8d2795a135d , but it would be good time to move to C99

nashidau commented 3 years ago

Pull request sent to move to std-c99 for gcc/clang.

nashidau commented 2 years ago

This can be closed right?

syoyo commented 2 years ago

@nashidau Oh yes. closed via https://github.com/syoyo/tinyobjloader-c/pull/46