search

syphon-org / syphon

⚗️ a privacy centric matrix client
https://syphon.org
GNU Affero General Public License v3.0
1.04k stars 72 forks source link

Key backup not saved #626

Closed notramo closed 2 years ago

notramo commented 2 years ago

It takes a lot of time to generate the backup, and it shows a green banner that says the backup is saved in Documents, but I can't find the file. Tested on Android. Permissions are granted for the app. I still find backups from other versions, so it's probably a regression.

ereio commented 2 years ago

strange. just checked on a Pixel 3a GrapheneOS Android 12 off dev and it saved successfully to Documents.

I didn't see it at first though, I had to navigate to the raw directory as it didn't show when navigating from "Documents" from the shortcut in my file viewer because it wasn't considered a "Large File", which is an automatic filter when viewing Documents from there.

I'll keep an eye out for it. Can you check the directory in termux by chance?

notramo commented 2 years ago

I see a backup, but that was made from an earlier version.

0-st commented 2 years ago

It also fails when the documents folder is missing

ereio commented 2 years ago

@0-st you mind making a separate issue for this? I cannot recreate the backup not saving when there is a documents folder but would like to fix the folder missing issue asap

notramo commented 2 years ago

I found out it was saved to Documents, but it doesn't show up in the Documents filetype category of the LineageOS stock file manager, only when browsing the raw directories. Probably it's not recognised as a text document by the file manager.

What about downloading it to Downloads? The LineageOS file manager doesn't apply MIME type filtering to Downloads, as it does with Documents. Also, this would make AppArmor confinement easier on Linux, because unnecessary permission for Documents is not needed. Access to Downloads is granted anyway as downloading attachments happens there. (I want to make an AppArmor profile for Syphon.)