fix: ignore unused snapshots for skipped test

syrupy-project / syrupy

:pancakes: The sweeter pytest snapshot plugin

https://syrupy-project.github.io/syrupy/

Apache License 2.0

542 stars 37 forks source link

fix: ignore unused snapshots for skipped test #862

Closed AllanChain closed 2 months ago

AllanChain commented 7 months ago

Description

This PR tracks the skipped tests and don't mark a snapshot as unused if the corresponding test is skipped.

Related Issues

Closes #787
Closes #842

Checklist

[ ] This PR has sufficient documentation.
[x] This PR has sufficient test coverage.
[x] This PR title satisfies semantic convention.

Additional Comments

No comments.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
+ Coverage   98.30%   98.31%   +0.01%     
==========================================
  Files          20       20              
  Lines        1530     1545      +15     
==========================================
+ Hits         1504     1519      +15     
  Misses         26       26

noahnu commented 2 months ago

@all-contributors add @AllanChain for bug

allcontributors[bot] commented 2 months ago

@noahnu

I've put up a pull request to add @AllanChain! :tada:

noahnu commented 2 months ago

:tada: This PR is included in version 4.6.3 :tada:

The release is available on:

v4.6.3
GitHub release

Your semantic-release bot :package::rocket: