Make API changes more consistent - Githubissues

syrusakbary / promise

Ultra-performant Promise implementation in Python

MIT License

362 stars 76 forks source link

Make API changes more consistent #22

Closed LivInTheLookingGlass closed 7 years ago

LivInTheLookingGlass commented 7 years ago

You said in my last pull requests that you liked my API changes. I figured that I would take those changes to their logical conclusion, and see what you thought of them.

Basically this ensures PEP8 format, moves state flags to an external class, and makes state and value private.

All tests have been updated to reflect this.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 99.583% when pulling 2b48eb170375d7ca05cb4729759cd18127ec7016 on gappleto97:master into 8322fb74f11ea1d3b6b0cac92b85e54a7d09f463 on syrusakbary:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 67945abcd4fa23de02efd7ffb46a5ffee4509b21 on gappleto97:master into 8322fb74f11ea1d3b6b0cac92b85e54a7d09f463 on syrusakbary:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 67945abcd4fa23de02efd7ffb46a5ffee4509b21 on gappleto97:master into 8322fb74f11ea1d3b6b0cac92b85e54a7d09f463 on syrusakbary:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 67945abcd4fa23de02efd7ffb46a5ffee4509b21 on gappleto97:master into 8322fb74f11ea1d3b6b0cac92b85e54a7d09f463 on syrusakbary:master.

LivInTheLookingGlass commented 7 years ago

Note that the failure is from mypy.

promise/promise.py:427: error: Argument 1 to "done" of "Promise" has incompatible type partial[None]; expected Callable[..., Any]

Looking at it, that's not a line that I changed, so I'm confused as to why it's failing now.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 4b61f2a321a97248679038febb229cd2725aeb98 on gappleto97:master into 8322fb74f11ea1d3b6b0cac92b85e54a7d09f463 on syrusakbary:master.