syrusakbary / promise

Ultra-performant Promise implementation in Python
MIT License
362 stars 76 forks source link

fix the loss of traceback #55

Closed ocavue closed 6 years ago

ocavue commented 6 years ago

this fix removes repr(e) who will lose the stack trace of the original exception

ocavue commented 6 years ago

I removed repr(e) because that will lose my stack trace information. It's hard to debug when I have thirty data loader and the exception only provide 'NoneType' object is not iterable. I also removed Data loader batch_load_fn function raised an Exception, which is a sweet but unnecessary message. It's easy to know that this error comes from a batch_load_fn function when you know which line raise it.

syrusakbary commented 6 years ago

Thanks for the fix! Merging

ocavue commented 6 years ago

You're welcome