On the react-native@0.0.9-rc default round indicator stucks on top of list

syrusakbary / react-native-refresher

A pull to refresh ListView for React Native completely written in js.

MIT License

453 stars 34 forks source link

On the react-native@0.0.9-rc default round indicator stucks on top of list #6

Open andrey-skl opened 9 years ago

andrey-skl commented 9 years ago

To reproduce: just upgrade to react-native 0.9.0-rc and try to refresh list. After release list indicator is overlaying it. Looks like breaking changes in react native can break refresher in near 0.9.0 realease

olliebrennan commented 9 years ago

I have noticed this also. It becomes more apparent for me with a 'minTime' specified - note, i am on react 0.10.0

ghost commented 9 years ago

Same issue.

ghost commented 9 years ago

The issue is here https://github.com/syrusakbary/react-native-refresher/blob/c5f641254c4ae9b472a87cf9925e37bf2c1e2c4f/lib/RefresherListView.js#L131 Seems that listviewscroll.scrollResponderIsAnimating() is true when it gets stuck and in addition, this.top is sometimes undefined. any number < undefined is always false.

syrusakbary commented 9 years ago

Thanks for pointing this out. Will improve this soon @blairvanderhoof