Replace deprecated imp module with importlib - Githubissues

syrusakbary / snapshottest

Snapshot Testing utils for Python 📸

MIT License

530 stars 103 forks source link

Replace deprecated imp module with importlib #166

Closed hugovk closed 2 months ago

hugovk commented 1 year ago

This project's tests use the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Raised PendingDeprecationWarning since 3.4 (2014)
Raised DeprecationWarning since 3.5 (2015)
Updated DeprecationWarning to say removal in 3.12 since 3.10 (2021)
Removal planned for 3.12 (2023)

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

https://github.com/syrusakbary/snapshottest/blob/24b8b4702f4c56eef7525e62b6fec90168125e42/snapshottest/module.py#L36

bblanchon commented 5 months ago

With Python 3.12, we now get the following error:

ModuleNotFoundError: No module named 'imp'

Please merge one of the available PRs 🙏