search

sys-bio / SBMLNetwork

SBMLNetwork is a library designed to enable software developers and systems biologists to interact with the graphical representation of SBML (Systems Biology Markup Language) models.
MIT License
0 stars 0 forks source link

Require the 'reactionGlyphIndex' argument. #8

Closed luciansmith closed 5 days ago

luciansmith commented 1 week ago

There were already functions with that argument, and implementation of these functions was broken. It was also causing me confusion because there was a difference between the 'get' functions and the 'set' functions. Removing the functions without reactionGlyphIndex seems to have just fixed everything, and made things simpler to boot.

adelhpour commented 6 days ago

These 'set' functions was written as reactionGlyphIndex = 0 is a very common case. Each of them has an equivalent where you can pass reactionGlyphIndex as an input argument (those are the ones which are considered to be parallel with 'get' functions). I fixed the issue you were encountering in PR #11. I just merged it into the 'develop' branch. You can check and see if it works fine.

luciansmith commented 6 days ago

I don't like it. When you are coding, you just get a bunch of functions with different numbers of 'int' arguments, and it's too confusing. I would just remove these functions.

adelhpour commented 5 days ago

You are right. Just merged it!