search

sys-bio / rrplugins

Plugins for Telluirum
http://sys-bio.github.io/rrplugins
Other
2 stars 5 forks source link

python reports version teplugins 1.0.0 for teplugins-1.0.11 #5

Closed mgaldzic closed 10 years ago

mgaldzic commented 10 years ago

The following is not really appropriate behavior. I don't think anyone cares about the wrapper version. The functionality is in the underlying C++ API, that is what changes for the user.

If needed to distinguish, create a new version variable version_python_wrapper

This occurs here: init.py

This version is refereing to the version of the Python wrapper itself, not

the version of the underlying C++ API

version = '1.0.0' ~

mgaldzic commented 10 years ago

fixed formatting of comment online

TotteKarlsson commented 10 years ago

This is appropriate. To get version of C++ API you call getVersion() method. To get version of Python module, read the python version string. This version string should be updated when the python code changes.