sys-bio / tellurium

Python Environment for Modeling and Simulating Biological Systems
http://tellurium.analogmachine.org/
Apache License 2.0
107 stars 36 forks source link

Transition away from graphviz #172

Open kirichoi opened 7 years ago

kirichoi commented 7 years ago

Few functions in Tellurium (namely draw()) utilizes graphviz which is an external application to Python. It would be nice to transition into something purely Python as graphviz support in Windows is not ideal. Something like networkx or plotly might do it.

hsauro commented 7 years ago

Talk to Matthias about this.

Herbert

On Mon, Apr 10, 2017 at 4:14 PM, Kiri Choi notifications@github.com wrote:

Few functions in Tellurium (namely draw()) utilizes graphviz which is an external application to Python. It would be nice to transition into something purely Python as graphviz support in Windows is not ideal. Something like networkx or plotly might do it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sys-bio/tellurium/issues/172, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAZDj_-0eD-lCjYZydFi5ZUZr7NLZBcks5rurfhgaJpZM4M5bvE .

kirichoi commented 7 years ago

I am thinking of keeping graphviz functionality but add a Python-based graphing tool and set that as the default. Using graphviz as backend can be done through something like:

rr.draw(backend='graphviz')

@matthiaskoenig: how does that sound?

matthiaskoenig commented 7 years ago

Sounds good to me.

On Apr 13, 2017 2:23 AM, "Kiri Choi" notifications@github.com wrote:

I am thinking of keeping graphviz functionality but add a Python-based graphing tool and set that as the default. Using graphviz as backend can be done through something like:

rr.draw(backend='graphviz')

@matthiaskoenig https://github.com/matthiaskoenig: how does that sound?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sys-bio/tellurium/issues/172#issuecomment-293743279, or mute the thread https://github.com/notifications/unsubscribe-auth/AA29ur2j2z15d3KjT7Zaife6Ww5SRItUks5rvWr0gaJpZM4M5bvE .

kirichoi commented 7 years ago

Did some preliminary work on this and realized that networkx using matplotlib backend is functional but very limited and ugly. It might be even better to focus on figuring out good way to distribute graphviz. Another solution might be utilizing our network viewer.

kirichoi commented 5 years ago

NetworkX now supports directed graph. I have a simple package I built that takes antimony strings and plots out network diagrams and it looks okay.

hsauro commented 5 years ago

Can you post an image.

H

On Mon, Oct 15, 2018 at 1:53 PM Kiri Choi notifications@github.com wrote:

NetworkX now supports directed graph. I have a simple package I built that takes antimony strings and plots out network diagrams and it looks okay.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sys-bio/tellurium/issues/172#issuecomment-430008899, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAZDol204xGE55NUh0GeDMpRINjp3Bwks5ulPWLgaJpZM4M5bvE .

-- Herbert Sauro, Associate Professor University of Washington, Bioengineering 206-685-2119, www.sys-bio.org hsauro@uw.edu Books: http://books.analogmachine.org/

kirichoi commented 5 years ago

Looks something like this:

image

Still needs a lot of polishing, but seems functional and the fact that it does not require any external binaries is a huge plus.

hsauro commented 5 years ago

Looks ok. What does it do for bimolecualar reactions?

H

On Mon, Oct 15, 2018 at 2:57 PM Kiri Choi notifications@github.com wrote:

Looks something like this:

[image: image] https://user-images.githubusercontent.com/7672320/46980693-32bb4c80-d08a-11e8-97db-28c23d9b17cd.png

Still needs a lot of polishing, but seems functional and the fact that it does not require any external binaries is a huge plus.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sys-bio/tellurium/issues/172#issuecomment-430028533, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAZDkqNRXC8GpEYJr47YazJ39j0ogw2ks5ulQSFgaJpZM4M5bvE .

-- Herbert Sauro, Associate Professor University of Washington, Bioengineering 206-685-2119, www.sys-bio.org hsauro@uw.edu Books: http://books.analogmachine.org/

kirichoi commented 5 years ago

I am working on those right now. I should be able to implement activation and inhibition in next few days. Also working on curved arrows.