sys-bio / temp-biomodels

Temporary place for coordination of updating existing Biomodels
Creative Commons Zero v1.0 Universal
2 stars 2 forks source link

SED-ML file points to non-existing model name #141

Closed maurosilber closed 1 year ago

maurosilber commented 1 year ago

For example, the OMEX contents for BIOMD0000001072 are:

    location                                format                                                                 master
--  --------------------------------------  ---------------------------------------------------------------------  --------
 0  .                                       https://identifiers.org/combine.specifications/omex                    False
 1  ./manifest.xml                          https://identifiers.org/combine.specifications/omex-manifest           False
 2  ./metadata.rdf                          https://identifiers.org/combine.specifications/omex-metadata           False
 3  Erratum.pdf                             https://purl.org/NET/mediatypes/application/pdf                        False
 4  Phillips2013.cps                        https://purl.org/NET/mediatypes/application/xml                        False
 5  Phillips2013.sedml                      https://identifiers.org/combine.specifications/sed-ml                  False
 6  Phillips2013.xml                        https://identifiers.org/combine.specifications/sbml.level-2.version-4  True
 7  SDE_library_setup.m                     https://purl.org/NET/mediatypes/application/x.unknown                  False
 8  diff_equations_article_deterministic.m  https://purl.org/NET/mediatypes/application/x.unknown                  False
 9  execute_example_MATLAB.txt              https://purl.org/NET/mediatypes/text/plain                             False
10  mySDE_sdefile.m                         https://purl.org/NET/mediatypes/application/x.unknown                  False
11  spider_basic_no_light_article.jpg       https://purl.org/NET/mediatypes/image/jpeg                             False
12  spider_sde_H_no_light_article.jpg       https://purl.org/NET/mediatypes/image/jpeg                             False
13  spider_sde_V_m_no_light_article.jpg     https://purl.org/NET/mediatypes/image/jpeg                             False
14  spider_sde_V_v_no_light_article.jpg     https://purl.org/NET/mediatypes/image/jpeg                             False

but the SED-ML file Phillips2013.sedml points to a non-existing model model.xml:

<?xml version="1.0" encoding="UTF-8"?>
<!-- Created by COPASI version 4.40 (Build 275) on 2023-06-14 11:31 with libSBML version 5.19.4. -->
<sedML xmlns="http://sed-ml.org/sed-ml/level1/version4" xmlns:sbml="http://www.sbml.org/sbml/level3/version1/core" level="1" version="4">
  <listOfModels>
    <model id="model" language="urn:sedml:language:sbml" source="model.xml"/>
  </listOfModels>
  ...
</sedML>

Is this an error or does the SED-ML or OMEX specifications say that I should load the master file Phillips2013.xml?

362 of the current 374 OMEX files with SED-ML have this issue. I'm attaching a file with all the model IDs:

mismatch_between_SEDML_and_OMEX_model_names.txt

maurosilber commented 1 year ago

It seems it has been already fixed in the final directory.