sys1yagi / mastodon4j

mastodon client for java, kotlin https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md
MIT License
135 stars 28 forks source link

userNameおよびpasswordはURLエンコードが必要です #56

Closed hero-matsumoto closed 6 years ago

hero-matsumoto commented 6 years ago

Apps.postUserNameAndPassword()のuserNameとpasswordは、+などの文字が入る可能性があるためURLエンコードが必要かと思います。個別にエンコードすべきかと考えたのですが、ここの全てのパラメータはエンコード済みの文字列が来ることはないと思いParameterでまとめてエンコードしました。

codecov-io commented 6 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage     58.25%   58.25%           
  Complexity      147      147           
=========================================
  Files            44       44           
  Lines           745      745           
  Branches         60       60           
=========================================
  Hits            434      434           
  Misses          297      297           
  Partials         14       14
Impacted Files Coverage Δ Complexity Δ
...in/java/com/sys1yagi/mastodon4j/api/method/Apps.kt 96.42% <100%> (ø) 5 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ae30f6...be67525. Read the comment docs.

sys1yagi commented 6 years ago

thank you!