sys1yagi / mastodon4j

mastodon client for java, kotlin https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md
MIT License
135 stars 28 forks source link

NullableかNotNullかをAPIドキュメントに沿って変更 #59

Closed moko256 closed 6 years ago

moko256 commented 6 years ago

ドキュメントに従って、ドキュメントにNullableと書かれているentityのattributeをNullableにしました

sys1yagi commented 6 years ago

thank you so much!

sys1yagi commented 6 years ago

OMG, the test failed 😭 please fix it :bow:

codecov-io commented 6 years ago

Codecov Report

Merging #59 into master will not change coverage. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     54.25%   54.25%           
  Complexity      147      147           
=========================================
  Files            44       44           
  Lines           800      800           
  Branches         80       80           
=========================================
  Hits            434      434           
  Misses          352      352           
  Partials         14       14
Impacted Files Coverage Δ Complexity Δ
.../com/sys1yagi/mastodon4j/api/entity/Application.kt 33.33% <0%> (ø) 1 <0> (ø) :arrow_down:
...a/com/sys1yagi/mastodon4j/api/entity/Attachment.kt 100% <100%> (ø) 7 <2> (ø) :arrow_down:
...in/java/com/sys1yagi/mastodon4j/api/entity/Card.kt 100% <100%> (ø) 5 <1> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e1320f...294f1b4. Read the comment docs.

sys1yagi commented 6 years ago

🙌