Date isn't displayed correctly on web view

Dreytac commented 2 months ago

First Check

[X] This is not a feature request
[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the documentation, with the integrated search.
[X] I already read the docs and didn't find an answer.

Homebox Version

v0.12.1

What is the issue you are experiencing?

I haven't used Homebox since September 2023 when this issue was still there. There is a complete thread on the issue at the old tracker:

https://github.com/hay-kot/homebox/issues/236

Seems it was never fixed as I'm still having the issue with a brand new install of v0.12.1. The bug seems to boil down to the front-end Javascript not converting the date/time correctly from the API when in certain timezones. In my case it's displayed as the day BEFORE the day the API returns. This causes an issue when you then save the item as it saves it using the displayed date/time.

How can the maintainer reproduce the issue?

Be in AEST timezone.
Create new instance of Homebox v0.12.1.
Create a new item with a purchase date (for example: 07/13/2024).
Observe the date is displayed as the day prior (eg: 2024-07-12).
Edit item and observe date is incorrect (eg: 07/12/2024).

Deployment

Unraid

Deployment Details

No response

SuperOlle commented 1 month ago

Can confirm that it's the same on my instance! I always have to pick the day AFTER the day I'm ACTUALLY wanting to put as date of purchase 😂

This ALSO causes the date to move backwards EVERYTIME you change something and then save it!

Docker on Ubuntu server VM.

katosdev commented 1 month ago

I'm struggling to replicate this and am thinking it might be related to locale... Will continue digging 😄

Dreytac commented 1 month ago

I think we came to the conclusion before that when submitting dates, it was submitting the date in whatever locale the app defaults to but then, when displaying that date back, it's converting it to the users locale, causing it to change. I think the problem was capturing the users locale when submitting the date was an issue.

I believe the date being shown in the API should be in the app default locale? Whereas when I submit a date and check the API, it returns it as the date I submitted (ie. in my locale).

OmegaDeathBunny commented 3 weeks ago

This is annoying so I would be willing to sponsor fixing this bug.

saschabrockel commented 1 week ago

I have the same now before it worked. Probably really an issue with the local time we are in. When I edit after midnight it works but if I edit during the day it's the behavior you all described.

katosdev commented 1 week ago

This is annoying so I would be willing to sponsor fixing this bug.

Thanks for the kind offer - If sponsoring, you can use the /boss command.

I'll be picking this one back up to try and do some more digging :)

sysadminsmedia / homebox