sysadminsmedia / homebox

A continuation of HomeBox the inventory and organization system built for the Home User
https://homebox.software
GNU Affero General Public License v3.0
797 stars 42 forks source link

Registration allows non-emails in email field #48

Closed tankerkiller125 closed 2 weeks ago

tankerkiller125 commented 2 months ago

First Check

Homebox Version

0.11.0

What is the issue you are experiencing?

The registration (and thus login as well) allows non-email addresses into the email field. While in theory this doesn't break anything (you can still login with whatever you put in) it does make it extremely confusing if you were moving quickly and entered the wrong thing into the wrong fields.

How can the maintainer reproduce the issue?

Enter anything into the email field during registration. It will be accepted with zero validation on the client side or server side.

Deployment

Docker (Linux), Other

Deployment Details

No response

RomuloGatto commented 2 weeks ago

Hey @tankerkiller125, I know it was on you, but it was such a quick fix that I just did that, hope you don't mind. Please, take a look at the PR.