search

sysapps / tcp-udp-sockets

Raw sockets API
86 stars 25 forks source link

Rename ReadyState to SocketReadyState #68

Closed schien closed 10 years ago

schien commented 10 years ago

The ReadyState enum is not possible to be reused out side of Raw Socket API and will cause confusion since many APIs have their own 'readyState' attribute. Rename it to SocketReadyState will make the usage more clear.

marcoscaceres commented 10 years ago

Agree. It should be renamed.

ClaesNilsson commented 10 years ago

Even though the Web Socket API's readyState attribute currently is not an enum type it might be better to instead rename the TCP and UDP Socket API's ReadyState enum to TCPUDPReadyState in order to avoid any future confusion with Web Sockets. WDYT?

schien commented 10 years ago

It's clear for me to identify the usage if we choose SocketReadyState for Socket API (i.e. TCP & UDP socket API) and WebSocketReadyState for WebSocket API. IMO the term "socket" has been associate with TCP and UDP for a long time because of the POSIX socket API.

ClaesNilsson commented 10 years ago

Ok, thanks schien. I don't have a strong opinion so if there are no objections I'll change it to SocketReadyState.