search

sysapps / telephony

API to manage telephony calls
16 stars 12 forks source link

Dial and telephone number format #189

Closed marcoscaceres closed 10 years ago

marcoscaceres commented 11 years ago

In the dial method, it's not well defined that it's the telephony service that handles invalid phone numbers.

zolkis commented 11 years ago

We need to specify the valid formats with references. In this version of the spec we support GSM and CDMA. In subsequent versions SIP and XMPP calls may be supported. All this have well defined remote party formats (will need to find the exact references).

marcoscaceres commented 11 years ago

I tried feeding the iOS a random string... it converts it all to numbers :) Weird.

zolkis commented 11 years ago

OK, some implementations may want to add skype, too. Other formats may be supported by some implementation, but that is the decision of the implementation, and it would not be compliant. Such apps may fail on other implementations.

marcoscaceres commented 11 years ago

I think this is then best left to the backend, right?

zolkis commented 11 years ago

The advantage of tel URI's is that all this is standardized.

marcoscaceres commented 11 years ago

Excuse my ignorance, but what does an XMPP number(?) look like?

zolkis commented 11 years ago

http://xmpp.org/rfcs/rfc6122.html

zolkis commented 11 years ago

I think this is then best left to the backend, right?

It depends whether do we require implementations to validate user strings for security reasons, or do we push that to the backends. We could do a pre-validation (length, encoding etc), and leave the rest to the backends.

marcoscaceres commented 11 years ago

I think for V1 we should just leave it all to the backends and see how we go... if people complain during review, we can start imposing rules.

zolkis commented 11 years ago

OK. We can create a note, eventually.

marcoscaceres commented 11 years ago

Clarified this in https://github.com/marcoscaceres/telephony/commit/4e876273a474f1752a352dc03b67ff3809870793

zolkis commented 10 years ago

Closing.