search

sysapps / telephony

API to manage telephony calls
15 stars 12 forks source link

Fix startTone method description #88

Closed efullea closed 11 years ago

efullea commented 11 years ago

-Description of 'tone' parameter states it is a sequence of the following characters (0-9; A-D; *; #), whereas it shuld be just one of these characters -Description of 'param' parameter should state that 'delay' should be ignored

zolkis commented 11 years ago

Thanks Eduardo, work started.

zolkis commented 11 years ago

Note that the 'gap' parameter is used, it is the 'duration' parameter which is ignored.

efullea commented 11 years ago

Do we really want to delay the start of that long tone according to the 'gap' parameter? IMO this parameter just makes sense when automatically emiting a sequence of tones (using sendTones), but not in this case. Wjhat is the use case behind?

zolkis commented 11 years ago

Same reasoning as in #102

marcoscaceres commented 11 years ago

I think maybe we should just clarify the text a little bit. @efullea concern is valid in that it might confuse readers - though @zolkis wording is correct. Should we add a small note or example?

zolkis commented 11 years ago

I can add clarification to the text - feel free to take it forward then.