Closed kprinssu closed 5 years ago
Hi thank you so much! I want to merge it but it shows merge conflicts ๐
Hi thank you so much! I want to merge it but it shows merge conflicts ๐
Iโll rebase and apply some additional clean up so there arenโt conflicts with master.
Awesome! I will test it today then merge it!
Few things to note:
VoodooI2C*
to VoodooPS2*
?)Nice! As for the renaming, sounds good to me:)
Hi @kprinssu , I've tested it on my Precision M3800, and this driver is really good!
In short, the two finger gestures (left/right swipe forward/back), three finger taps, dragging, work like a charm. I have a MacBookPro 13, 2018 with Touch Bar, and I feel these touchpad is quite usable now!
Thank you so much!
@kprinssu could you please tell me why this implementation will make the touchpad much precise and smoother, I'm really looking forward to the details. Thank you in advance!
Good to hear! I still find that it still abit jerky and will require more tuning.
There are more changes from VoodooI2C that I want to backport but this PR should be good to go, unless you want me to clean up code.
Thank you, I've already submitted a collaboration request for you ๐
I am creating this PR to show that it is possible to enable native multitouch on PS/2 trackpads. My laptop comes with a Synaptics PS/2 trackpad and this is a more of a PoC than anything else.
A lot of the work here was hacked together using VoodooI2C's native multi touch engine (though it's from an older commit) and the synaptics driver from the Linux kernel.
It currently supports 3+ fingers gestures so it should fully support most of Macbooks gesture. However, my laptop only seems to support a max of three fingers and gestures sometimes feel off.
I also had emulate the third finger since the trackpad doesn't report back on more than 2 fingers.
Based on Rehabman's upstream branch, but should be relatively easy to backport the changes. Feel free to edit and merge the code at your leisure.