search

syscl / OS-X-Voodoo-PS2-Controller

Contains updated Voodoo PS/2 Controller, improved Keyboard & Synaptics TouchPad
Other
18 stars 5 forks source link

Physical left click button + drag is not working #11

Open yusufrahadika opened 5 years ago

yusufrahadika commented 5 years ago

I build your latest source to kext. It works, but my physical left click button not work anymore to simulate drag when combined with touchpad. How to enable that function again? Thank you.

kprinssu commented 5 years ago

I also have this issue on my HP Spectre 13. Not sure what the cause of the problem is and I will need to do more testing/debugging to figure what exactly Apple's MT stack doesn't like with the PS/2 generated data.

yusufrahadika commented 5 years ago

Are this issue possible caused by VoodooI2C? Because I ever tried VoodooI2C in another laptop, when I use VoodooI2C v2.0.1 my click button can simulate drag. But after updating to v2.1.2 my click button not work anymore to simulate drag. But I still not sure which commit between v2.0.1-v2.1.2 that create this problem. Thank you.

kprinssu commented 5 years ago

Small footnote/correction: It's not necessarily VoodooI2C (it's not the I2C driver, but instead it's more than likely the Magic Trackpad simulator. I ported an older version of the simulator which ma be causing the problems.

I'll ask Alexandred Daoud for more details on the issue.

yusufrahadika commented 5 years ago

Hello @kprinssu , I just build VoodooPS2Controller from your repository. Sometimes I facing mistouch when typing, is "Ignore input when typing" not implemented or I missing some configurations? Because VoodooI2C with MT2 Simulator seems already implement that function, refer to https://github.com/alexandred/VoodooI2C/issues/142#issuecomment-450726690 . Or that function implemented by using your VoodooI2CELAN kext? And my 2 fingers tap sometimes captured as scroll gesture. Can I make higher tolerance, so my fingers small move still captured as tap? Thank you.

kprinssu commented 5 years ago

Palm rejection is not implemented, but since we are using PS2 controller, we can set up a listener to listen for the keyboard controller messages (see https://github.com/kprinssu/VoodooI2CELAN/commit/7254794eb7ba5522f182f80578de5995827fa404).

I should have the latest set of changes from VoodooI2C within my branch, my suggestion is to compare the changes across the forks.

yusufrahadika commented 5 years ago

I just try to copy that commit in your latest version but palm rejection still not working. Are I doing something wrong? My files attached below. Thank you.

VoodooI2CMT2SimulatorDevice_cpp.txt VoodooI2CMT2SimulatorDevice_hpp.txt

kprinssu commented 5 years ago

Sorry, but I am not going to help you debug it since I do not have the time or the hardware at hand to help you. It will also be much easier to read if you hosted those files on a Github branch.

yusufrahadika commented 5 years ago

Sorry, here it is my commit. https://github.com/yusufrahadika/OS-X-Voodoo-PS2-Controller/commit/f2af5e67d881b9d764684132b2b695e57a491e6b

Thank you.