search

syscl / XPS9350-macOS

macOS patches for Dell XPS 13 9350 (Skylake)
916 stars 73 forks source link

TYPE C hot plug #159

Open Yui-Huang opened 7 years ago

Yui-Huang commented 7 years ago

Hi, Could your XPS9350 Type C hot plug work?

my laptop is Dell Latitude 5480, it could not hot plug,

I'm search method to let it work, do you have any idea?

Thanks

Yui-Huang commented 7 years ago

OK I fix it.

DSDT.dsl.zip

RockJesus commented 7 years ago

How did u fixed it?

Yui-Huang commented 6 years ago

@RockJesus modify the DSDT

Yui-Huang commented 6 years ago

I got the Dell TB15 yesterday, the TB3 is no hot plug, I have to plug in before boot, and the type-c on the TB15 is no hot plug, either. @syscl do you have any idea? I bought the TB15 from taobao, it is not expensive.

Yui-Huang commented 6 years ago

EFI_IOReg_patchmatic_Termianl.zip

kdb424 commented 6 years ago

Any work done on this? I have an almost perfect system thanks to the work done here. After waking from sleep (hotplug) I lose my dock until reboot. I'm not an expert on DSDT patching to know what to do here. Thanks!

x4080 commented 6 years ago

@sdarktemplar how to patch with your attachment?

kdb424 commented 6 years ago

https://www.tonymacx86.com/threads/usb-c-hotplug-not-working.223534/ Seems like some work for general hotplug and TB3 are going on here. I thought I'd cross reference for those interested.

quanlou commented 6 years ago

@sdarktemplar sorry, i cant compile your dsdt, pls help me :D screen shot 2018-02-07 at 11 21 21 pm

maz-1 commented 5 years ago

Some progress on type-c hotplug:

https://github.com/hackintosh-stuff/XPS9350-macOS/blob/master/DSDT-backup/SSDT-XHC-alt/SSDT-XHC.dsl This is the ssdt currently I am using. It force-power the thunderbolt controller upon boot/wakeup. There is a expresscard tray icon, but eject the controller from tray icon will cause panic due to IOThunderboltFamily. Must detach type-c before wakeup.

https://github.com/hackintosh-stuff/XPS9350-macOS/blob/master/DSDT/SSDT-XHC.dsl Another ssdt similar to xps 15 9550 setup. Does not force-power thunderbolt controller, IOThunderboltFamily not loaded. Must attach type-c device before boot to make it work. Detach type-c device will eject XHC2 as well, and eject XHC2 from expresscard tray menu also works without panic. Re-attach type-c device does not bring XHC2 back. If XHC2 is ejected before sleep, when wake up with type-c already attached, XHC2 will be detected by IOPCIFamily again. If XHC2 is not ejected before sleep, XHC2 will not work as well.

I think the second approach would be better as long as we find out a way to tell IOPCIFamily to rescan PCI devices when attach type-c device.

@syscl