syscl / XPS9350-macOS

macOS patches for Dell XPS 13 9350 (Skylake)
917 stars 74 forks source link

ALC256 #28

Open syscl opened 7 years ago

syscl commented 7 years ago

Dear Mirone,

Here's the result with the latest AppleALC + CodecCommander + ALCPlugFix

snip20170115_3

Funny thing is there's "Use audio port for 'Sound Output'" or "Use audio port for 'Sound Input'". I switched Sound Output to Sound Input, but still no mic detect.

Thanks for your help, syscl

syscl commented 7 years ago

Hi Mirone, the latest one AppleHDA even cannot load

Here's the screenshot snip20170115_1

syscl

syscl commented 7 years ago

Dear Mirone,

The latest AppleHDA:

Some very tiny noise/coil buzzing when headphone is plugged in, I then switched my version of CodecCommander, see here This version reduce the headphone noise but not eliminated it totally. Maybe the problem is in CodecCommander and ALCPlugFix's arguments?

Thanks in advance, syscl

x4080 commented 7 years ago

Hi, I just found out that I have headphone noise if :

And there's no headphone noise if :

nos1609 commented 7 years ago

@syscl check my AppleALC.kext Headphones, mic and speakers works perfectly. But we have to remove a ghost input device from this config.

syscl commented 7 years ago

@nos1609 Thank you! I will try then merge it if possible.

Do you have some idea to lower down the power consume?

syscl

syscl commented 7 years ago

Hi @Mirone,

here's the latest AppleHDA's screenshot, snip20170128_1

syscl

syscl commented 7 years ago

Hello @Mirone snip20170129_2

Working:

Not working:

What I've always test:

If without CodecCommander, there will be very tiny noise using headphone. Anyway, this version is pretty good(no intensive noise from headphone w/o CodecCommander :).

Thank you! syscl

syscl commented 7 years ago

@Mirone snip20170129_3

Working:

Not working:

syscl

syscl commented 7 years ago

Hi @Mirone

Here's the ioreg+origin ACPI ioreg+ACPI.zip

Thank's for your time, syscl

syscl commented 7 years ago

Hi @Mirone

Here's the result: snip20170130_5 snip20170130_4

There's no sound input from headphone and internal mic. I double check from my friend's MacBookPro who sat behind me, that once I plug-in my iPhone's headphone, then Input->External Mic, and input level change when I tap the headphone.

I am very appreciate your help, syscl

syscl commented 7 years ago

Hi @Mirone

Here's the result snip20170130_2

All test with CodecCommander and without CodecCommander.kext.

syscl

syscl commented 7 years ago

Hi @Mirone

You remind me, I notice there's indeed internal speaker, and funny thing is, once I plug in headphone or unplug headphone, there'll be input level change instantly: snip20170130_6

BTW, no matter I plug in or unplug headphone, there will be tiny pop in headphone. Seems a good indicate?

Thank you!! syscl

syscl commented 7 years ago

Hello @Mirone

This AppleHDA is pretty cool! Internal mic works and very sensitive! :)

Working:

Not working:

I saw you've changed DSDT as well: do you inject more properties for Device (HDEF) ?

Here's the result: snip20170203_1

Pretty pretty nice.

Have a nice day, syscl

x4080 commented 7 years ago

Already included in the deploy?

syscl commented 7 years ago

@x4080 No, not yet, still waiting Mirone's refining. He will refine it tonight.

syscl

x4080 commented 7 years ago

Cool

nos1609 commented 7 years ago

@syscl could you please share the dylibs after so I could make a new applealc

syscl commented 7 years ago

Hi @nos1609

I will, but the kext is yet to complete.

Thank you, syscl

syscl commented 7 years ago

Hello @Mirone

How are you?

I have a question, is the layoutID = 36 means I will see Audio ID = 36 in System Information -> Audio? I tried two of the latest AppleHDA with 0x01, 0x03, 0x24, 0x36, none of them have sound

snip20170206_2

Do I do something wrong?

Thank you, syscl

syscl commented 7 years ago

CloverV2.zip

syscl

nos1609 commented 7 years ago

Maybe this can help somehow. It is the output of audio init under linux.

syscl commented 7 years ago

@nos1609 @bozma88 @ZombieTheBest about headphone pop issue, please try this from AppleALC

<dict>
                <key>Comment</key>
                <string>AppleHDA anti-pop patch #1 (credit AppleALC)</string>
                <key>MatchOS</key>
                <string>10.11.x,10.12.x</string>
                <key>Name</key>
                <string>com.apple.driver.AppleHDA</string>
                <key>Find</key>
                <data>QcYGAEiLu2g=</data>
                <key>Replace</key>
                <data>QcYGAUiLu2g=</data>
            </dict>
            <dict>
                <key>Comment</key>
                <string>AppleHDA anti-pop patch #2 (credit AppleALC)</string>
                <key>MatchOS</key>
                <string>10.11.x,10.12.x</string>
                <key>Disabled</key>
                <true/>
                <key>Name</key>
                <string>com.apple.driver.AppleHDA</string>
                <key>Find</key>
                <data>QcaGQwEAAAA=</data>
                <key>Replace</key>
                <data>QcaGQwEAAAE=</data>
            </dict>

Though I haven't experienced any noise pop.

syscl

syscl commented 7 years ago

@x4080 @nos1609 @bozma88 @ZombieTheBest

I just want you all know that I have fixed the Headphone internal issue, and know it works pretty pretty nice. Except the display in mic is still internal mic(not a big issue).

Sorry, I speak too soon. Need more testing.

syscl

mircoianese commented 7 years ago

@syscl You mean the headphone microphone? That's nice! I will wait for that :D I also saw the "noise pop" fix, @bozma88 said that it's inefficient because that patch keeps the codec active. How much "inefficient" it is in terms of power consumption?

syscl commented 7 years ago

Inefficient is not what we consider in the first place, bear in mind, in hackintosh world, the first thing is to make things can be used, then we consider elegant method.

syscl

bozma88 commented 7 years ago

@syscl, I think that is a choice that every user has to make. Some of us (e.g. myself) purchased this laptop because of its huge battery life that current-gen MacBook cannot reach. So, for example, my main aim is to make it last on battery as long as possible.

Mirone commented 7 years ago

hi @syscl do you solved the problem with ComboJack?

x4080 commented 7 years ago

@syscl Good job, I'll try it

syscl commented 7 years ago

Dear @Mirone

Long time no see. How are you?

Sadly, I cannot replicate the external microphone to work again. Though I still use my original AppleHDA, maybe that's the reason why I cannot power the ext mic again. I want to tried your version of AppleHDA with my new finding(because ext mic is almost finished), but there's too many versions. And our conversation on insanelymac has been removed such that I cannot download suitable version to have a try. :(

syscl

Mirone commented 7 years ago

hi, @syscl Which version do you need?

syscl commented 7 years ago

Hello @Mirone , sorry for my late reply, maybe the most recently one. I got a totally corrupted system now. And all your AppleHDA on that laptop cannot be rescued.

I will respond once I fix my laptop.

Thank you, syscl

bozma88 commented 7 years ago

@syscl: http://a.co/aDbQlPA + http://a.co/6XUN0ig + Time Machine = ❤️

PankovSerge commented 7 years ago

Hello @syscl, any news about alc256?

syscl commented 7 years ago

Hello @PankovSerge @x4080 @nos1609 @ZombieTheBest @bozma88 , I'v merged @MuntashirAkon\'s HDA patch audio should work fine now, layout-id=1.

Thank you in advance, syscl

PankovSerge commented 7 years ago

Hi, @syscl !

Can you please provide some instruction, how i can use sound patch from commit e3f8127

Thank you!

syscl commented 7 years ago

Hi @PankovSerge just simply execute deploy.sh in terminal, that's it.

syscl