search

syscl / XPS9350-macOS

macOS patches for Dell XPS 13 9350 (Skylake)
916 stars 73 forks source link

Fork or branch for XPS 9360 #61

Open R1MnTnA opened 7 years ago

R1MnTnA commented 7 years ago

@syscl I would like to ask for your blessing/approval that I fork your project and create a new one for the XPS 13 9360 model. I will need to adjust several things obviously, so I don't know if it would be wise or better for me to do pull requests, start a new (not forked repo) or just keep the fork and keep it in a separate branch, because I don't want to create any chaos or problems when viewing what you and @squash- has forked and changes you both have been working on and/or his pull requests. Do you have any recommendations on how best to do this and are you okay with me modifying your script in my repo? I have read the FAQ and instructions, but I'm still a little confused on how best to do this. Or would you prefer if I contributed to your repo and create a new script that will be strictly for the 9360? For example Deploy-9360.sh? And at the same time try to help contribute with similar issues or bugs since the two systems have a few similarities. When you have time please let me know your thoughts. Thank you.

syscl commented 7 years ago

@R1MnTnA Thank you, I'm really appreciate people like you who have dedication.

In short(I'm busy this month, sorry), 9360 and 9350 have almost the same procedures of patches, which means we can use a minor modified deploy.sh to patch 9360 as well. I need testers who will give me report such that I can let this deploy support both 9350 and 9360 in only a single script!

Transplant deploy to XPS9360 you need the following steps(skeleton)

Thank you, syscl

R1MnTnA commented 7 years ago

@syscl That's fantastic! 1 script for both would be the best! And No worries, I understand you have a lot of studying and exams, so we can collaborate more when you have time. In the meantime I will work on some of it in my branched repo and then help contribute to yours. I will get the info you requested. Is there a better way that you prefer I connect with you? Maybe through Slack, other app or just post here or you can maybe even create a new project up at the top under the tab 'Projects' and add notes. - https://help.github.com/articles/adding-notes-to-a-project/ Instead of being an "issue" here, because obviously it's not. :-D

R1MnTnA commented 7 years ago

@syscl I uploaded my ioreg file in case you need it, also my output from HWiNFO64 from windows. https://github.com/R1MnTnA/XPS9360-macOS/tree/9360

syscl commented 7 years ago

Thank you, I will look into it later this month.

syscl

R1MnTnA commented 7 years ago

Just leaving this here for your reference, so when you have time later next month you can view what instructions patches I've been using for my 9360. https://www.tonymacx86.com/threads/guide-dell-xps-13-9360-on-macos-sierra-10-12-x-lts-long-term-support-guide.213141/

wilvancleve commented 7 years ago

Just wanted to bump this thread and ask where you are with a 9360 install? There are several references to the 9360 in change logs, and before I get started trying to install on my 9360 QHD, I wanted to better understand my chances of success?

Thanks!

mashnoon33 commented 7 years ago

^

R1MnTnA commented 7 years ago

@wilvancleve @mashnoon33 You are still better off following the guide in the tonymac forums that I posted the link to. Unfortunately at this point this deploy.sh puts too many patches to the DSDT and SSDT files that mess up the 9360, the audio doesn't work and the screen glitches on boot up. As for the QHD screen if you follow the directions on that guide you need to change your DVMT to 96mb and I use the 19260004 in Clover for the intel platform-id.